Cl 937 bedrock #33
Merged
Cl 937 bedrock #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…group (rebuy-de#1229) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roup across 1 directory (rebuy-de#1246) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Curious about this. If we already know the pattern, wouldn't we filter them out in this module like other modules do? |
swhite-oreilly
suggested changes
Sep 16, 2024
There was a problem hiding this comment.
@corybekk we need to add properties functions similar to something like this as they are asking for those upstream:
func (f *CodePipelineCustomActionType) Properties() types.Properties {
properties := types.NewProperties()
properties.Set("Category", f.category)
properties.Set("Owner", f.owner)
properties.Set("Provider", f.provider)
properties.Set("Version", f.version)
return properties
}
@swhite-oreilly I thought this was optional. I am trying to find it, can you show me where it's being asked for upstream? Edit: Added them for good measure: 2e67160. Thanks for the callout.
@corybekk something is wrong with the filtering as well, when I run nuke all resources are successful except for that alias. |
Thanks @sstoops for pointing that out! I didn't realize there was an optional filter function being used in the pattern. Ive added it 5ea0b67 and will remove the settings.py filter that is in the companion PR. here is the updated output. aws-nuke version unknown - unknown - unknown edit: I removed the agent alias filter. It looks like we don't need it after all. 1e5142c |
@swhite-oreilly it looks like you weren't filtering out the alias. It needs to be added to config.yml. Nonetheless, as per Seans comment, I have added filtering here: 5ea0b67. You should now get this as output: I also removed the agent alias because it looks like in your example you had no issues with it. I also tested locally and didn't see the alias pop up. I'm doing a little more research on this alias. Just to make sure we really don't need it. |
swhite-oreilly
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
@corybekk pending my question to Sean regarding the go/editorconfig changes, I think this looks good. Thanks for adding the filter, I just had the original team ask for these as part of the standard setup going forward. The filtering worked correctly as well, thanks!
| @@ -0,0 +1,132 @@ | |||
| # Distributed via https://github.com/rebuy-de/terraform-cluster-config | |||
There was a problem hiding this comment.
Honestly, I think you've hacked on aws nuke more than I have at this point! It does look like the result of main not having been merged over to oreilly-main first. I'm not sure it's a big deal (especially given our entire uncertain future with aws nuke).
corybekk
pushed a commit
that referenced
this pull request
Nov 6, 2024
* docs: add note about continued attribution * chore: improve internal tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the
bedrock-flowalias.gomodule for deleting bedrock flow-alias resources.Added the
bedrock-agentalias.gomodule for deleting bedrock agent-alias resources.Observation
Note: Attempting to cleanup these resources in aws-nuke with their cloud control resource will result in the following errors:
Testing
you can use the
bedrock.shfrom the companion PR to create the flow and agent resources. It also might be helpful to comment out the other bedrock resources in the script unless they are already included in your cleanup config.Output