Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DF2TFilter IIR filters? #43

Open
sairus7 opened this issue Feb 14, 2024 · 3 comments
Open

DF2TFilter IIR filters? #43

sairus7 opened this issue Feb 14, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@sairus7
Copy link

sairus7 commented Feb 14, 2024

There is wrapper for FIR filters from DSP.jl.
What about IIR filters, like butter etc.?

@mchitre mchitre self-assigned this Feb 15, 2024
@mchitre mchitre added comment Further information is requested enhancement New feature or request and removed comment Further information is requested labels Feb 15, 2024
@mchitre
Copy link
Member

mchitre commented Feb 15, 2024

Currently SignalAnalysis.jl does not wrap any of the IIR filter functionality, but I'm open to suggestions on which ones are useful to have. Are you suggesting these 4? Anything else? Any suggestions on API?

@sairus7
Copy link
Author

sairus7 commented Feb 15, 2024

As an API example, I've made the following wrapper for my needs:

function butter(
    ftype::Type{<:FilterType},
    order::Int,
    fcut::Union{Number, NTuple{2,Number}},
    fs
)
    responsetype = ftype(fcut...; fs=fs)
    designmethod = Butterworth(order)
    return digitalfilter(responsetype, designmethod)
end

@mchitre
Copy link
Member

mchitre commented Feb 23, 2024

Will add in when I get a chance to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants