Refreshed Pull Request Commits Page Feedback

[willsmythe]

The pull request commits page has been refreshed to improve performance, improve consistency with other pages, and to make the experience more accessible!

To minimize disruptions, the capabilities of the classic commits page have been maintained, with a few exceptions: you can now use arrow keys to navigate the list of commits (instead of j and k) and focus indicators have been improved for better visual distinction.

Note: The roll-out of this refreshed page will begin on September 4, 2024.

Opt out

To switch back to the classic commits page, disable the "New Pull Request Commits Experience" feature preview (learn more).

Feedback

Have a question? Have feedback? Tell us below!

[JonathanRefera]

Worked well and fast. No bugs found. Good.

[Huucanh990]

Cảm thấy hoạt động khá OK

[tudel31]

yeah

[Rebellmw]

Top

[adlai]

I clicked the Thumbs-Down emoticon because there are bugs; it causes an endless loop of UX by notifying about new changes even after there are none. I have not isolated the test case, although I described the general set of circumstances in another comment's thread.

[hanzlahabib]

just minor UI

[nathanielop]

On pull requests with several commits- scrolling up too fast causes the header to jump before/after the sticky one is unrendered

[willsmythe]

Thanks for the feedback. Which browser are you seeing this on? And if you're able to capture a video of the problem, can you post it here? If not, no worries, we'll investigate regardless.

[maciejs-bp]

The difference in UX is quite big - at least on Chrome/Linux arrow keys scroll the page by default. Even after focusing the commit list with Tab I can only navigate a single commit group and nothing happens after selecting a commit with Return. On the old one I could navigate immediately with j/k (which feels natural to Vim users) and pressing Return opened the commit.

[willsmythe]

Thanks for the feedback.

• We plan on fixing the issue where you can't navigate the full list of commits with the down/up arrow keys
• We also plan on fixing the issue with Return/Enter not navigating to that commit
• We intentionally removed j and k support for accessibility reasons, but we're exploring ways to support them (but not impact accessibility). Stay tuned!

[LasseRafn]

• PR Author now has underline under the name, which is inconsistent with other PR UIs
  

• Diff no longer has decimal separators
  

• Scrolling fast, as reported by others, causes the page to jump up and down

[inkblotty]

@LasseRafn - Thank you for the report 🙏 On the first issue, do you have the Link Underline setting turned off? Just for additional context here.

[baptiste-n42]

I noticed that the deletion icons (red cubes) are striped on the commit page but not on the rest of the tabs. Maybe it's normal.

[nwnk]

[Araxeus]

This is unrelated to the refresh, it was like that before

[jesseduffield]

This may not be the right place to ask, but I'd like to have the option to view a page which shows file changes commit-by-commit, so it starts at the first commit with its description and file changes, and then you scroll down and eventually you reach the second commit with its file changes, etc. Currently I have to choose between:

1. Just looking at the final diff
2. Opening a new browser tab for each commit and then going through each tab

[thislooksfun]

When viewing a single commit on a PR there are prev/next buttons on the top-right of the commit message box. Additionally pressing n will go to the next commit and p will go to the previous one. It's not an infinite scroll, but it's still (imo) better than using multiple tabs, and I like the organization of having one commit per page so I don't get confused when scrolling back up and accidentally going too far.

[Araxeus]

Not a big fan of the new buttons, its not very clear at a glance that those are buttons unlike the old design

[Billonwill]

Definitely its irritative design

[jez]

There's a counterintuitive result in interface design where the ease with which a button can be clicked is proportional to the size of the button in the UI, not just the size of the click target.

In the new design, since there is no background around the button by default, it gives the impression to users that they must be precise in clicking only the text, so they'll slow down their mouse cursor as they get closer to the commit text.

If the commit button were to be larger, like it was in the old design, users will understand the click target to be larger and know that they don't have to be so precise in clicking the button, making it easier to click.

Posting because I've noticed myself doing this every time I go to click the new commit buttons, even though in my head I know that the clickable area is the same size as it always was. Would love if we could get a better visual indicator that these are buttons, not just links.

[Sebastian-Brud-Tectonic]

Broken branch names. It keeps saying release%2FXYZ is not a proper branch name. Broken feature

[aelnosu]

Hi, The verify tag is not being shown consistently. If the commit is signed with S/MIME the verified tag is different between the PR page and that individual patch page.

[aelnosu]

Personally, I would prefer the verified tag on the individual patch page, but I hope there is more space between the profile picture and the title.

[okarny]

I wish there was a view in which you could see when you submitted a review in the series of commits. So I know after I requested for changes then the Engineer makes commits following that I can look at those more closely.

[ShineZaw123]

good

[aaronmarkey]

Could we have some way to see the actual date and time commits were made? "Last week" is extraordinarily unhelpful.

[willsmythe]

Across GitHub (and on this page), you should be able to hover your mouse over "last week" or "3 days ago" or whatever and see the exact date and time in a tooltip, for example:

[hsuabina]

I think I found a bug. I have a PR opened, where I'm not seeing the last commit and I can't merge:

The PR view (note it ends in #35c6848e):

If I browse the branch commits, the last one is there (#219f454):

If I try to merge the PR I get this error:

In git (not github) the branch looks OK in the remote.

[hsuabina]

I checked today again and the last commit was finally showing in the PR commit list, and the PR could be merged.

Not sure if this was fixed or if it was a temporary glitch 🤷🏼

[inkblotty]

Thanks for the report either was @hsuabina - Please let us know if it resurfaces.

[hsuabina]

So far so good!

[nexdrew]

My team is seeing this today in one of our private repos. 3 commits on the branch but only 2 show in the PR.

[nexdrew]

Closing the PR and reopening it resolved the problem.

[Laurens256]

Small inconsistency that was mentioned here before but I'll add some extra info. With the accessibility setting "show link underlines" enabled, the PR author's username gets an underline in the "commits" tab but not in the other tabs

With the accessibility setting disabled none of them have underlines

[artismarti]

One thing that would be helpful (at least to me) is to make it obvious to distinguish the order of the commits - for the life of me I can never remember whether it is in descending or ascending order. Some kind of visual aid (other than committed x days ago) would be super handy!
Thank you :)

[matthew-ant]

Big +1 (the inconsistent orderings in various pages on github has caused me to make mistakes)

[jchesshirAspire]

Works just fine.

One extra suggestion. Change the default focus on this screen to be the first commit. Also, on the single commit page, give the Next key the default focus, unless it's disabled, then give it to Previous.

[chromakode]

Attempting to switch base branch to a branch containing a / in the name results in this error:

[fcole90]

Got the same problem! 🤕 Disabling the feature made it work perfectly ✅

[fabio-colella-md]

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated

Proposed base branch %2F was not found

Adding reference text in case someone googles this error 😊 🔍

[adlai]

This comment is a complaint about the page referenced by the topic of discussion; it is not disruptive, for it is reporting a problem with the User Experience of commenting simultaneously on individual code lines and the entire pull request simultaneously.

The "New changes since you last viewed [View changes]" button sometimes remains despite not being relevant anymore... it happened after a certain sequences of comments on individual lines and comments on entire commits.

I am not able to take screenshots on my current workstation.

[thislooksfun]

The changes overview display thing is wrapping weirdly for me. On other screens it shows the numbers inline and to the left of the squares, but on the commit list page the squares are below the numbers, and are slightly overlapping the bottom line.

[jpshack-at-palomar]

I see this also. Version 18.0 (20619.1.24.11.2) Same at any zoom level.

What stood out to me was that the boxes are sitting on the menu rule line.

[jamestelfer]

I'm seeing the same, using Brave 1.70.119 (Chromium: 129.0.6668.70).

[zxcodes]

The fact that GitHub.com isn't open-source is an irony in itself.

[nitendra-jangid-metacube]

On Commits page the squares are below the numbers, and touching the bottom line, but on other pages it is inline, it would be better to use inline like other pages

[agolubev-natlex]

The commits are ordered from old to new in 'Commits' tab on PR page.

It's not so convenient and neither consistent with general commits view for some branch.

[jpshack-at-palomar]

Overall works great for me. The one bit I did notice is that commits are ordered oldest first. For a long history I often want to see newest on top so I don't have to scroll down to see what has changed since I last looked. Having a toggle to show latest first would be great.

[VikramAtSage]

From where can I re-order the commits history to show Latest First. Its inverted for me?

[jpshack-at-palomar]

Something else I ran into tonight is that commits are listed by the commit date not the author date. Ordinarily this is as I would expect, but if a feature branch has been rebased on main and forced pushed--a common pattern for many teams that use feature branches--listing the commits by author date detail would be really helpful since the rebase sets all the commit dates to the time of the rebase. The author dates are still present and one can do git log --pretty=fuller to see them. But it would be nice if GitHub would show the commits by author date (or offer to) if the author data and commit date don't match.

[rgmz]

There appears to be a bug with the commit check indicator. It shows that my commit's checks have failed, however, both the Checks tab and the modal shows that they have passed. The issue persists after several minutes.

`deferred_commits_data` response (click to expand)

GET https://github.com/gitleaks/gitleaks/pull/1499/deferred_commits_data?start_entry=0

{
    "deferredCommits": [
        {
            "oid": "1eb37c219a4dbfc100707f766a63e880dc3c87bf",
            "commentCount": 0,
            "statusCheckStatus": {
                "state": "failure",
                "short_text": "0 / 1 checks OK"
            },
            "verifiedStatus": "unsigned",
            "signatureInformation": {
                "signatureVerificationReason": "unsigned",
                "hasSignature": false,
                "verifiedAt": null,
                "isViewer": null,
                "keyExpired": null,
                "keyId": null,
                "keyRevoked": null,
                "signedByGitHub": false,
                "signerAvatarUrl": null,
                "signerLogin": null,
                "signatureCertificateSubject": null,
                "signatureCertificateIssuer": null,
                "signatureType": null
            },
            "onBehalfOf": null
        }
    ],
    "nextIndex": 1,
    "loadMore": false,
    "loading": false
}

[rgmz]

Conversely, the summary shows "1/1" passed when the modal shows failure.

[AdamShwert]

Do you have a link to this PR? Or is it a private repo?

[nitendra-jangid-metacube]

It's showing the last month for a commit, but it's from September 3rd, which is the current month, should be fixed!

[sivasankaran-k-scalgo]

Is this right? It's wrapped down / left aligned.

Browser: Google Chrome 128.0.6613.119 (64-bit)
O.S.: Ubuntu 24.04.1 LTS