An issue with "gh release create" and published assets

[lystopad]

Select Topic Area

Bug

Body

Hello

I found not all assets published when I run "gh release create".

Here you can find sample code how it could be reproduced:

Github workflow:

name: Testing gh release create glob
run-name: "gh release create"

on:
  workflow_dispatch:
    inputs:
        version:
          required: true
          type: string
          default: '0.1.2'
          description: 'Version'
    
jobs:  
  testing-gh-release-create:
    runs-on: ubuntu-22.04
    timeout-minutes: 10
  
    steps:
  
        - name: Checkout git repository
          uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 ## 4.1.7 release
          with:
            fetch-depth: 0
            ref: 'main'

        - name: Create test archives
          run: |
            date > archive_${{ inputs.version }}_linux_arm64.tar.gz
            install archive_${{ inputs.version }}_linux_arm64.tar.gz archive_${{ inputs.version }}_linux_amd64.tar.gz
            install archive_${{ inputs.version }}_linux_arm64.tar.gz archive_${{ inputs.version }}_linux_amd64v2.tar.gz
            install archive_${{ inputs.version }}_linux_arm64.tar.gz archive_${{ inputs.version }}_darwin_amd64.tar.gz
            install archive_${{ inputs.version }}_linux_arm64.tar.gz archive_${{ inputs.version }}_darwin_arm64.tar.gz
            install archive_${{ inputs.version }}_linux_arm64.tar.gz archive_${{ inputs.version }}_darwin_amd64v2.tar.gz
            chmod a=r *.tar.gz
            ls -l *.tar.gz

        - name: Perform release
          env:
            GH_TOKEN: ${{ github.token }}
          run: |
            gh release create *.tar.gz \
                --generate-notes \
                --target main \
                --draft=true \
                --title "${{ inputs.version }}" \
                --notes "Version ${{ inputs.version }} released"

Expected outcome:

• 6 assets published

Actual outcome:

• 5 assets published.

Workflow output:

Run date > archive_0.0.2_linux_arm64.tar.gz
  date > archive_0.0.2_linux_arm64.tar.gz
  install archive_0.0.2_linux_arm64.tar.gz archive_0.0.2_linux_amd64.tar.gz
  install archive_0.0.2_linux_arm64.tar.gz archive_0.0.2_linux_amd64v2.tar.gz
  install archive_0.0.2_linux_arm64.tar.gz archive_0.0.2_darwin_amd64.tar.gz
  install archive_0.0.2_linux_arm64.tar.gz archive_0.0.2_darwin_arm64.tar.gz
  install archive_0.0.2_linux_arm64.tar.gz archive_0.0.2_darwin_amd64v2.tar.gz
  chmod a=r *.tar.gz
  ls -l *.tar.gz
  shell: /usr/bin/bash -e {0}
    
-r--r--r-- 1 runner docker 29 Sep 23 11:47 archive_0.0.2_darwin_amd64.tar.gz
-r--r--r-- 1 runner docker 29 Sep 23 11:47 archive_0.0.2_darwin_amd64v2.tar.gz
-r--r--r-- 1 runner docker 29 Sep 23 11:47 archive_0.0.2_darwin_arm64.tar.gz
-r--r--r-- 1 runner docker 29 Sep 23 11:47 archive_0.0.2_linux_amd64.tar.gz
-r--r--r-- 1 runner docker 29 Sep 23 11:47 archive_0.0.2_linux_amd64v2.tar.gz
-r--r--r-- 1 runner docker 29 Sep 23 11:47 archive_0.0.2_linux_arm64.tar.gz

2s
Run gh release create *.tar.gz \
  gh release create *.tar.gz \
      --generate-notes \
      --target main \
      --draft=true \
      --title "0.0.2" \
      --notes "Version 0.0.2 released"
  shell: /usr/bin/bash -e {0}
  env:
    GH_TOKEN: ***

And I see only 5 published assets:

archive_0.0.2_darwin_amd64v2.tar.gz 29 Bytes 12 minutes ago
archive_0.0.2_darwin_arm64.tar.gz 29 Bytes 12 minutes ago
archive_0.0.2_linux_amd64.tar.gz 29 Bytes 12 minutes ago
archive_0.0.2_linux_amd64v2.tar.gz 29 Bytes 12 minutes ago
archive_0.0.2_linux_arm64.tar.gz 29 Bytes 12 minutes ago

I expect 6 assets will be published as they all matching *.tar.gz pattern.
Why only 5 assets published?

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[Chanduporalla]

The issue with only 5 assets being published instead of the expected 6 when using the gh release create .tar.gz command is likely due to how the shell is expanding the wildcard (.tar.gz) and passing the filenames to the command. If one of the files is not being passed or recognized correctly, it could cause only 5 assets to be uploaded.

Here are some possible reasons and solutions to consider:

1. File Visibility and Timing

Ensure that all files are correctly created and visible at the time the gh release create command is executed. There might be a race condition where one file is not completely written or not accessible at the moment the wildcard is expanded.

Fix: Add a delay before the gh release create step or explicitly list the files to confirm that all 6 archives are present:

bash

ls -l *.tar.gz

2. File Naming Collision or File System Caching

The wildcard expansion relies on the file system. If there is any caching or if two files have similar names that might be causing a conflict, one file may be missed during the expansion.

Fix: Use an explicit list of files instead of relying on *.tar.gz:

bash

gh release create archive_${{ inputs.version }}linux_arm64.tar.gz archive${{ inputs.version }}linux_amd64.tar.gz archive${{ inputs.version }}linux_amd64v2.tar.gz archive${{ inputs.version }}darwin_amd64.tar.gz archive${{ inputs.version }}darwin_arm64.tar.gz archive${{ inputs.version }}_darwin_amd64v2.tar.gz
--generate-notes
--target main
--draft=true
--title "${{ inputs.version }}"
--notes "Version ${{ inputs.version }} released"

3. Issue with gh release create Command Handling Multiple Files

Sometimes the GitHub CLI (gh) can have issues when uploading multiple files using wildcard patterns. If one file fails to upload, it might silently skip that file without throwing an error.

Fix: Explicitly mention each file or iterate over the files and upload them one by one:

bash

for file in *.tar.gz; do
gh release upload ${{ inputs.version }} "$file"
done

4. File Size or Content Issue

If one of the files has a specific issue (corrupt, zero size, or some other anomaly), it might not be uploaded. Even though it is created and visible, the gh release create might silently ignore it.

Fix: Verify the size and contents of all 6 files before the upload to ensure they are valid and non-empty.
Next Steps

Check Logs: Look for any error messages or warnings in the output of the gh release create step.
Test with Different Wildcards: Try a smaller scope with gh release create archive_${{ inputs.version }}_*.tar.gz and see if the behavior changes.

By addressing these potential causes, you should be able to ensure that all 6 assets are uploaded as expected.

[lystopad]

Hi
it was my mistake.
According to the gh manual :

USAGE gh release create [<tag>] [<files>...]
first non-flag parameter is a tag. So, in my case it is the lost file from the list of files.
I was wrong to think that a tag in square brackets could be skipped.
Sorry for the noise.