Low contrast when browsing GitHub profiles while using the "new" Dark Default theme

[bandisast]

Select Topic Area

Bug

Body

Greetings, everyone.

A few minutes ago, I noticed that, (probably) after the recent colour contrast changes, the colour contrast actually feels lower when browsing user profiles. In specific:

Dark default:
Background: #0d1117
Repo names $ hyperlinks: #3f84e4 (5.07:1 contrast with the background)
Repo descriptions: #7a8490 (4.98:1 contrast with the background)

Now, comparing with the protanopia/deuteranopia/tritanopia themes, which appear to be using the old colours for these divs:
Background: #0d1117
Repo names & hyperlinks: #58a6ff (7.49:1)
Repo descriptions: #8b949e (6.15:1)

I assume it doesn't feel like a huge difference to users that have a "20/20 vision", but as someone with moderate myopia, I'd suddenly find it a bit harder to browse profiles on GitHub without using my glasses, zooming in more, or crouching towards the screen. Would it be possible to replace #3f84e4 with #58a6ff and #7a8490 with #8b949e on the Dark Default theme?

EDIT: I see this now also applies to quoted text etc. GitHub definitely will be harder to use.
EDIT #2: Sadly, I have now moved to the not-as-good-looking Dark High-Contrast theme, as the normal theme is partially unusable for me now.

[lukasoppermann]

Hey @bandisast,

thank you for your feedback. The issue we are having with the the previous link and muted color (e.g. used for repo descriptions) is that both don't have a 3:1 contrast ratio to the default color. However this is required by wcag 2.1 to assure users can distinguish links from text. This leaves us in a mathematically very tight spot.

[fwcd]

The problem, as mentioned in the other thread, is that human color perception is not linear and e.g. a color on dark background needs a different (higher) contrast ratio than a color on light background. This comment from the other thread summarizes it well.

It would be nice to at least have the option to make the accent color brighter (without using the dimmed theme, which makes the background brighter and thereby lowers contrast again).

[karmaral]

Oh no, I was hoping it was a bug of sorts. I'm using the Dark Dimmed theme and suddenly the whites are really bright and the blues have become more dark and saturated... it feels really noisy.

Thanks for posting the old colors, might have to work around it with an extension.

[lukasoppermann]

Hey @karmaral this is something we will be addressing.

[karmaral]

Thank you, indeed the visual needles are gone!

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[A6976]

Select Topic Area

Bug

Body

Greetings, everyone.

A few minutes ago, I noticed that, (probably) after the recent colour contrast changes, the colour contrast actually feels lower when browsing user profiles. In specific:

Dark default: Background: #0d1117 Repo names $ hyperlinks: #3f84e4 (5.07:1 contrast with the background) Repo descriptions: #7a8490 (4.98:1 contrast with the background)

Now, comparing with the protanopia/deuteranopia/tritanopia themes, which appear to be using the old colours for these divs: Background: #0d1117 Repo names & hyperlinks: #58a6ff (7.49:1) Repo descriptions: #8b949e (6.15:1)

I assume it doesn't feel like a huge difference to users that have a "20/20 vision", but as someone with moderate myopia, I'd suddenly find it a bit harder to browse profiles on GitHub without using my glasses, zooming in more, or crouching towards the screen. Would it be possible to replace #3f84e4 with #58a6ff and #7a8490 with #8b949e on the Dark Default theme?

EDIT: I see this now also applies to quoted text etc. GitHub definitely will be harder to use. EDIT #2: Sadly, I have now moved to the not-as-good-looking Dark High-Contrast theme, as the normal theme is partially unusable for me now.

[lukasoppermann]

I will look into this. Thanks for the report.