Upload limit is ignored

[tessus]

I have set max_content_length = "50MB", but whenever I upload a file larger than 50MB, the entire file is uploaded and only then I get the error message that the limit is exceeded.

rpaste

limit_rpaste.mp4

curl

limit_curl.mp4

[orhun]

The middleware was implemented in #53 and yes, it turns out it is broken. I just reproduced this issue.

What would be the way of going forward with fixing this? Should we check HEAD requests, or do something in the middleware? Any ideas?

[tessus]

What would be the way of going forward with fixing this?

At one point I read a comment (but I am not sure in which repo or issue/discussion) that there is now a native way with the new versions of actix and/or actix-multipart which should render the middleware obsolete.

I've been looking for that comment frantically, but unfortunately haven't found it yet.

[orhun]

It would be the best way of moving forward if something like that exists. Custom implementations are not always infallible, like we saw in this case :D

[tessus]

I think I found it: https://stackoverflow.com/a/78399675

[orhun]

That's superb, can you try it out?

One thing to note that we probably won't be able to change this on the fly since it's configured while the App is constructed.

[tessus]

Not sure when I get to it, but yes, I would like to.

[tessus]

I tried it, but unfortunately no difference. Maybe there's an issue with the Byte arithmetic. I am quite puzzled by this.
When I get to it, I'll open a draft PR and you can have a look at my attempt to make it woek with the "new" way of doing it according to the stackoverflow comment. Maybe I fucked it up though...

[orhun]

Yup, shoot me a draft whenever you can!

[tessus]

This (#360) was supposed to work, but it doesn't. I am not sure how to solve this. I can't believe nobody ever got this to work.

[orhun]

We both seem quite puzzled by this. Maybe a gentle ping to the actix master @robjtede would help us out a bit 😊