Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename table types to end in Table #27

Closed
rly opened this issue Jan 3, 2020 · 0 comments · Fixed by #49
Closed

Rename table types to end in Table #27

rly opened this issue Jan 3, 2020 · 0 comments · Fixed by #49
Assignees
@oruebel
Milestone
Release V 0.2.0

Comments

@rly
Copy link
Collaborator

rly commented Jan 3, 2020

@bendichter and I would prefer the convention of having subtypes of DynamicTable end in "Table", similar to how we name descendants of TimeSeries with "Series". See discussion here: NeurodataWithoutBorders/nwb-schema#337 (comment)

To conform with this convention, I suggest changing: IntracellularRecordings, SweepSequences, Runs, and Conditions to IntracellularRecordingsTable, SweepSequencesTable, RunsTable, and ConditionsTable. The 'name' can remain as is, without the 'Table' suffix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oruebel oruebel

Labels
None yet
Projects
None yet
Milestone
Release V 0.2.0
Development

Successfully merging a pull request may close this issue.

Update names of neurodata_types, assigned names, and corresponding code oruebel/ndx-icephys-meta
2 participants
@rly @oruebel