-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better automatic Polymake banner hiding #412
Comments
Info: Do you also think that the Oscar banner should be hidden in this case? (I currently assume so) |
In my current setup of a package depending on Oscar, I get both the Polymake and the Oscar banner. It would be great if the Polymake banner could be suppressed (as are GAP, Singular, Hecke,...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My students are writing a package which depends on Oscar. Loading their package in Julia 1.8.2 shows the Oscar banner, but also the Singular and Polymake banners. We have logic in place which is supposed to prevent this. Perhaps it needs to be update in a similar fashion to what @thofma did in oscar-system/GAP.jl#826 ?
(Perhaps we should move this logic into a helper function and put it into a helper package that is then used by GAP.jl, Singular.jl, Polymake.jl -- this way we only need to update this and a few other things in only one place? Or even without the package, if there was an identical helper function used in all three packages, updating it would be easier).
See also oscar-system/Singular.jl#611
The text was updated successfully, but these errors were encountered: