Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather layer alpha slider don't change it immidietely #20533

Closed
nnngrach opened this issue Aug 7, 2024 · 9 comments · Fixed by #20596, #20964, #21013 or #21146
Closed

Weather layer alpha slider don't change it immidietely #20533

nnngrach opened this issue Aug 7, 2024 · 9 comments · Fixed by #20596, #20964, #21013 or #21146
Assignees
Labels
Milestone

Comments

@nnngrach
Copy link
Contributor

nnngrach commented Aug 7, 2024

Description

video:

2024-08-07.22.02.13.mp4

Steps to reproduce

  1. Configure map -> Weather -> Temperature
  2. Turn layer on
  3. Change Transparency slider position

Actual result

Weather only blinks, but layer alpha doesn't change at all for tiles on the screen. Only new loaded tiles (after map moving) will have new alpha value.

Expected result

Weather layer alpha changes immediately for tiles on the screen

Your Environment (required)

WARNING Crash-Logs MAY contain information you deem sensitive.
Review this CAREFULLY before posting your issue!

OsmAnd Version: Nightly 4.9.0#2939m, released 20204-08-07
Android/iOS version: Android 9
Device model: Samsung Galaxy S10
Crash-Logs: ?
@nnngrach
Copy link
Contributor Author

nnngrach commented Aug 7, 2024

This code can fix the problem, but I don't sure if this is a correct way.

Screenshot 2024-08-07 at 22 55 53

@DmitryAlexei
Copy link
Contributor

reproduced on Samsung galaxy note 20 Android 13 OsmAnd~ 4.9.0#2932m, released: 2024-08-07

2024-08-08.00.30.54.mp4

@DmitryAlexei DmitryAlexei modified the milestones: 4.9-map, 4.9-android Aug 7, 2024
@vshcherb
Copy link
Member

vshcherb commented Aug 8, 2024

Cache needs to be cleared after transparency changed

Chumva added a commit that referenced this issue Aug 14, 2024
…eather

#20533: Apply transparence to weather layer when slider chenged
@DmitryAlexei
Copy link
Contributor

OsmAnd~ 4.9.0#3024m, released: 2024-08-19
Works very slow on my device

2024-08-19.17.56.52.mp4

@dmpr0 dmpr0 reopened this Aug 20, 2024
@dmpr0
Copy link
Contributor

dmpr0 commented Aug 20, 2024

Review

  • Slider lag

@dmpr0
Copy link
Contributor

dmpr0 commented Oct 7, 2024

Review

21%? 20%? Video
temperatureslider.mov
  • Slider updates with the lag

@dmpr0
Copy link
Contributor

dmpr0 commented Oct 14, 2024

Review 2

Start value 10% Set to 100%, reopen Video
weather.mp4
  • Unable to set transparency with confidence it will be the same after reopening

@vshcherb
Copy link
Member

Previous #21040 was reverted, no decision was made and new bug introduced

@vshcherb
Copy link
Member

vshcherb commented Oct 15, 2024

  • Slider should apply immediately to settings and to values on UI
  • Progress bar should be shown until changes are not applied on UI preview (until all calculations are finished) - cancelled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment