Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group translations for all POI types with lang="true" #20697

Closed
2 tasks done
dmpr0 opened this issue Aug 27, 2024 · 3 comments · Fixed by #20891
Closed
2 tasks done

Group translations for all POI types with lang="true" #20697

dmpr0 opened this issue Aug 27, 2024 · 3 comments · Fixed by #20891
Assignees
Labels
Milestone

Comments

@dmpr0
Copy link
Contributor

dmpr0 commented Aug 27, 2024

Description

We need to group into one line translations for all poi types that can have it, currently we do it for: name, alt name, old name.

ToDo

  • Group translations
  • Use the same UI as for Name tag
@vshcherb vshcherb added this to the 4.9-android milestone Aug 27, 2024
@vshcherb vshcherb added the and-ui label Sep 3, 2024
@DmitryAlexei
Copy link
Contributor

iOS task - osmandapp/OsmAnd-iOS#3951

@nazar-kutz
Copy link
Contributor

Potential Future Tasks to Improve User Experience

  1. Some tags arrive without explicit localization. For example, a point may include three tags describing a brand: "brand", "brand:uk", "brand:en". Currently, the "brand" tag is displayed without specifying the locale associated with it. However, it’s generally accepted that tags without a locale should be assigned the locale of the country where the point is located. Therefore, we can link such non-localized tags to the current locale of the object to display it on the UI. For example, for points located on the Ukraine, display "Brand: Ukrainian", not "Brand".

  2. Some points have more localized tags than what the app receives. For instance, the OSM website displays several localized versions of the "operator" tag for a specific point (https://www.openstreetmap.org/node/2343609267). However, OsmAnd only receives the general (non-localized) "operator" tag, while the others with extensions are lost somewhere. This might also need fixing.

  3. We have a significant issue with dividers between items on the Context Menu. They disappears between some menu rows. This requires additional time for investigation and fixing, and it might need to be addressed as a separate task.

@vshcherb
Copy link
Member

  1. "Brand" should be translated as "Brand", later we can add "Local brand" if there are multiple
  2. easy to fix by @xmd5a2
  3. have separate issue

xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Sep 25, 2024
@vshcherb vshcherb removed the doc-👍 label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants