Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Orderbook]: Wire up tick to price conversion into market filling logic #43

Closed
Tracked by #16
AlpinYukseloglu opened this issue Feb 24, 2024 · 1 comment
Closed
Tracked by #16

[Orderbook]: Wire up tick to price conversion into market filling logic #43

AlpinYukseloglu opened this issue Feb 24, 2024 · 1 comment
Assignees
@crnbarr93

Comments

@AlpinYukseloglu
Copy link
Collaborator

Background

Currently, market fills use placeholder values for price. Once #41 is merged, we should wire it up to the logic implemented in #40 and test higher level market orders.

Suggested Design

Replace TODOs in market fill logic with tick_to_price

Acceptance Criteria

  • New functionality is implemented and tested
@AlpinYukseloglu AlpinYukseloglu mentioned this issue Feb 24, 2024
Closed
27 tasks
@crnbarr93 crnbarr93 self-assigned this Feb 26, 2024
@crnbarr93 crnbarr93 mentioned this issue Feb 27, 2024
Closed
@AlpinYukseloglu
Copy link
Collaborator Author

Addressed in #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crnbarr93 crnbarr93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Orderbook]: Wiring up tick to price to fulfillments osmosis-labs/orderbook
2 participants
@crnbarr93 @AlpinYukseloglu