Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colcon Tutorial #947

Closed
3 tasks
Yadunund opened this issue May 1, 2023 · 4 comments
Closed
3 tasks

Colcon Tutorial #947

Yadunund opened this issue May 1, 2023 · 4 comments

Comments

@Yadunund
Copy link
Member

Yadunund commented May 1, 2023

Check the documentation for the 'Colcon Tutorial' page

Setup

  • DDS vendor: FastDDS
  • BuildType: Debian
  • Os: Ubuntu Jammy
  • Chip: Amd64

Links

Checks

  • I was able to follow the documentation.
  • The documentation seemed clear to me.
  • The documentation didn't have any obvious errors.

You can find the code used to generate this test case here

@cdhabecker
Copy link

I'll take this one.

@cdhabecker
Copy link

cdhabecker commented May 4, 2023

Observations:

  1. This tutorial appears to be the major colcon doc in docs.ros.org. (I searched "colcon" in the "Search docs" field, and the hits are mostly colcon command lines.) In fact, https://docs.ros.org/en/iron/Installation/Alternatives/Ubuntu-Development-Setup.html refers to this tutorial for "More info on working with a ROS workspace...".

Problems

  1. "This is a brief tutorial on how to create and build a ROS 2 workspace with colcon. It is a practical tutorial and not designed to replace the core documentation." -> "core documentation" should be a link to https://colcon.readthedocs.io/.
  2. "Background" section -> delete it. https://colcon.readthedocs.io/ explains the relationship to catkin and gives the github link. As for the design document mentioned in this tutorial, not even https://colcon.readthedocs.io/ mentions it. Thus, it appears to be uninteresting.
  3. "Basics" section: too long, passive voice, vague. Also, this tutorial uses "--symlink-install", which counters the "out of source build" assertion in this section. Replace this entire section with: "A ROS workspace is a directory with a particular subdirectory structure. You place the source code packages in the src/ directory and colcon builds the source code into the build/, install/, and log/ directories."
  4. Sections "Setup colcon_cd", "Setup colcon tab completion" and "Tips" -> delete them. The colcon documentation should be the source of truth, and if that source of truth is deficient, fix it. This tutorial should have only ROS-specific additional information, and these sections do not contain any ROS-specific information.

@cdhabecker
Copy link

Checks
Other than the problems in the preceding comment:

  • I was able to follow the documentation.
  • The documentation seemed clear to me.
  • The documentation didn't have any obvious errors.

Tests passed
The build and test commands printed a bunch of known warnings as per colcon/colcon-core#454 (comment). Nevertheless, the tests passed.

The demo worked.

Shell output
https://gist.github.com/cdhabecker/942489fb7469bab375845de20591e79f

@Yadunund
Copy link
Member Author

Yadunund commented May 4, 2023

Thanks for testing this! Appreciate the valuable comments on improving documentation. Will continue tracking this and other suggestions to docs here #1047

I'll close this ticket as its considered completed

@Yadunund Yadunund closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants