From efaf1b2129929a298d89bcf52eab6ee694bec4e3 Mon Sep 17 00:00:00 2001
From: Alex Ruef <alex.ruef@oregonstate.edu>
Date: Wed, 4 Sep 2024 14:28:18 -0700
Subject: [PATCH] removed getting started and feedback links

---
 package.json                               |  2 +-
 src/features/__tests__/About.test.tsx      |  6 +----
 src/features/about/SupportResources.tsx    | 26 ----------------------
 src/ui/Footer.tsx                          | 13 -----------
 src/ui/HeaderNav/HelpMenu.tsx              | 10 ---------
 src/ui/MainNav/MobileMenuFooter.tsx        | 11 ---------
 src/ui/__tests__/Footer.test.tsx           |  4 +---
 src/ui/__tests__/Header.test.tsx           |  1 -
 src/ui/__tests__/HelpMenu.test.tsx         | 13 -----------
 src/ui/__tests__/MobileMenuFooter.test.tsx |  3 +--
 yarn.lock                                  |  8 +++----
 11 files changed, 8 insertions(+), 89 deletions(-)

diff --git a/package.json b/package.json
index ccf1e6c9..30eb3639 100644
--- a/package.json
+++ b/package.json
@@ -13,7 +13,7 @@
     "@osu-wams/hooks": "1.0.146",
     "@osu-wams/lib": "0.1.87",
     "@osu-wams/theme": "0.1.6",
-    "@osu-wams/utils": "0.0.29",
+    "@osu-wams/utils": "0.0.30",
     "@reach/accordion": "^0.11.2",
     "@reach/dialog": "^0.11.2",
     "@reach/menu-button": "^0.10.5",
diff --git a/src/features/__tests__/About.test.tsx b/src/features/__tests__/About.test.tsx
index 152d8db6..40dc4735 100644
--- a/src/features/__tests__/About.test.tsx
+++ b/src/features/__tests__/About.test.tsx
@@ -40,12 +40,8 @@ describe('<About />', () => {
 
   it('should have support resources links that are tracked via GA', () => {
     render(<About />);
-    const started = screen.getByText(/getting started/i);
     const getHelp = screen.getByText(/Get help/i);
-    const giveFeedback = screen.getByText(/Give us feedback/i);
-    userEvent.click(started);
     userEvent.click(getHelp);
-    userEvent.click(giveFeedback);
-    expect(mockGAEvent).toHaveBeenCalledTimes(3);
+    expect(mockGAEvent).toHaveBeenCalledTimes(1);
   });
 });
diff --git a/src/features/about/SupportResources.tsx b/src/features/about/SupportResources.tsx
index a5ba69b2..ece2acc5 100644
--- a/src/features/about/SupportResources.tsx
+++ b/src/features/about/SupportResources.tsx
@@ -4,8 +4,6 @@ import Icon from 'src/ui/Icon';
 import {
   faCogs,
   faUserHeadset,
-  faCommentAltLines,
-  faExternalLink,
 } from '@fortawesome/pro-light-svg-icons';
 import { Card, CardHeader, CardContent, CardIcon, CardFooter } from 'src/ui/Card';
 import {
@@ -25,18 +23,6 @@ const SupportResources: FC = () => {
       <CardHeader title="Support Resources" badge={<CardIcon icon={faCogs} />} />
       <CardContent>
         <List>
-          <ListItem>
-            <ListItemContentLinkSVG
-              href={Url.feedback.main}
-              target="_blank"
-              onClick={() => Event('about', 'feedback')}
-            >
-              <Icon icon={faCommentAltLines} color={themeContext.ui.list.item.link.color} />
-              <ListItemText>
-                <ListItemContentLinkName>Give us feedback on MyOregonState</ListItemContentLinkName>
-              </ListItemText>
-            </ListItemContentLinkSVG>
-          </ListItem>
           <ListItem>
             <ListItemContentLinkSVG
               href={Url.support.main}
@@ -49,18 +35,6 @@ const SupportResources: FC = () => {
               </ListItemText>
             </ListItemContentLinkSVG>
           </ListItem>
-          <ListItem>
-            <ListItemContentLinkSVG
-              href={Url.gettingStarted.main}
-              target="_blank"
-              onClick={() => Event('about', 'getting started')}
-            >
-              <Icon icon={faExternalLink} color={themeContext.ui.list.item.link.color} />
-              <ListItemText>
-                <ListItemContentLinkName>Getting started</ListItemContentLinkName>
-              </ListItemText>
-            </ListItemContentLinkSVG>
-          </ListItem>
         </List>
       </CardContent>
       <CardFooter></CardFooter>
diff --git a/src/ui/Footer.tsx b/src/ui/Footer.tsx
index f17c61c6..70841685 100644
--- a/src/ui/Footer.tsx
+++ b/src/ui/Footer.tsx
@@ -121,19 +121,6 @@ const Footer = () => {
               <br />
               Get Support
             </FooterIconLink>
-            <FooterIconLink
-              href={Url.feedback.main}
-              target="_blank"
-              onClick={() => Event('footer', 'Give Feedback link')}
-            >
-              <Icon
-                icon={faCommentAltCheck}
-                color={themeContext.footer.iconLink.icon.color}
-                size="2x"
-              />
-              <br />
-              Give Feedback
-            </FooterIconLink>
           </FooterButtonWrapper>
           <a
             href="https://oregonstate.edu/copyright"
diff --git a/src/ui/HeaderNav/HelpMenu.tsx b/src/ui/HeaderNav/HelpMenu.tsx
index 36186cb4..d69df9a7 100644
--- a/src/ui/HeaderNav/HelpMenu.tsx
+++ b/src/ui/HeaderNav/HelpMenu.tsx
@@ -37,16 +37,6 @@ const HelpMenu = () => {
             <Icon icon={faQuestionCircle} />
             Get Help
           </MenuLink>
-
-          <MenuLink
-            as="a"
-            href={Url.support.main}
-            target="_blank"
-            onClick={() => Event('header', 'help-button-menu', 'Give feedback link clicked')}
-          >
-            <Icon icon={faComment} />
-            Give feedback
-          </MenuLink>
         </HeaderNavList>
       </MenuPopover>
     </Menu>
diff --git a/src/ui/MainNav/MobileMenuFooter.tsx b/src/ui/MainNav/MobileMenuFooter.tsx
index a6948a79..04bfc313 100644
--- a/src/ui/MainNav/MobileMenuFooter.tsx
+++ b/src/ui/MainNav/MobileMenuFooter.tsx
@@ -19,17 +19,6 @@ const MobileMenuFooter = ({ toggleFullMenu, ...props }) => {
         <Icon icon={faQuestionCircle} />
         Help
       </MobileFooterLink>
-      <MobileFooterLink
-        as="a"
-        href={Url.feedback.main}
-        onClick={() => {
-          toggleFullMenu(false);
-          Event('footer-menu-nav', 'Feedback link clicked');
-        }}
-      >
-        <Icon icon={faComment} />
-        Feedback
-      </MobileFooterLink>
       <MobileFooterLink
         to={Routes.Routes().about.fullPath}
         onClick={() => {
diff --git a/src/ui/__tests__/Footer.test.tsx b/src/ui/__tests__/Footer.test.tsx
index 3718354a..c87f2a37 100644
--- a/src/ui/__tests__/Footer.test.tsx
+++ b/src/ui/__tests__/Footer.test.tsx
@@ -79,18 +79,16 @@ it('Links to be present and tracked in Google Analytics', async () => {
   renderWithUserContext(<Footer />, { user: mockUser() });
   //Profile icon click - this text is visually hidden
   const supportLink = screen.getByText('Get Support');
-  const feedbackLink = screen.getByText('Give Feedback');
   const copyrightLink = screen.getByText('Copyright');
   const disclaimerLink = screen.getByText('Disclaimer');
   const accessibilityLink = screen.getByText(/Accessibility Information/);
 
   userEvent.click(supportLink);
-  userEvent.click(feedbackLink);
   userEvent.click(copyrightLink);
   userEvent.click(disclaimerLink);
   userEvent.click(accessibilityLink);
 
-  await waitFor(() => expect(mockGAEvent).toHaveBeenCalledTimes(5));
+  await waitFor(() => expect(mockGAEvent).toHaveBeenCalledTimes(4));
 });
 
 it('Application deployed versions', async () => {
diff --git a/src/ui/__tests__/Header.test.tsx b/src/ui/__tests__/Header.test.tsx
index 0593644c..e5462f63 100644
--- a/src/ui/__tests__/Header.test.tsx
+++ b/src/ui/__tests__/Header.test.tsx
@@ -50,7 +50,6 @@ describe('Student mobile menu interactions', () => {
     userEvent.click(helpMenu);
 
     expect(await screen.findByText(/get help/i)).toBeInTheDocument();
-    expect(await screen.findByText(/give feedback/i)).toBeInTheDocument();
     expect(await screen.findByText(/about myoregonstate/i)).toBeInTheDocument();
 
     const profileMenu = screen.getByRole('button', { name: /profile/i });
diff --git a/src/ui/__tests__/HelpMenu.test.tsx b/src/ui/__tests__/HelpMenu.test.tsx
index b909f223..b86292b4 100644
--- a/src/ui/__tests__/HelpMenu.test.tsx
+++ b/src/ui/__tests__/HelpMenu.test.tsx
@@ -18,19 +18,6 @@ it('Help button and Get Help link are in the menu and tracked via GA', async ()
   expect(mockGAEvent).toHaveBeenCalledTimes(2);
 });
 
-it('Feedback link tracked via GA', async () => {
-  render(<HelpMenu />);
-
-  userEvent.click(screen.getByRole('button', { name: /help/i }));
-
-  const feedbackLink = await screen.findByText('Give feedback', { selector: 'a' });
-
-  expect(feedbackLink).toBeInTheDocument();
-
-  userEvent.click(feedbackLink);
-  expect(mockGAEvent).toHaveBeenCalledTimes(2);
-});
-
 it('About MyOregonState link tracked via GA', async () => {
   render(<HelpMenu />);
 
diff --git a/src/ui/__tests__/MobileMenuFooter.test.tsx b/src/ui/__tests__/MobileMenuFooter.test.tsx
index d9967c01..e6a03d67 100644
--- a/src/ui/__tests__/MobileMenuFooter.test.tsx
+++ b/src/ui/__tests__/MobileMenuFooter.test.tsx
@@ -13,7 +13,6 @@ test('More menu has links that are tracked via Google Analytics', async () => {
 
   userEvent.click(screen.getByText('About'));
   userEvent.click(screen.getByText('Help'));
-  userEvent.click(screen.getByText('Feedback'));
 
-  expect(mockGAEvent).toHaveBeenCalledTimes(3);
+  expect(mockGAEvent).toHaveBeenCalledTimes(2);
 });
diff --git a/yarn.lock b/yarn.lock
index 059826be..0cd07a22 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2594,10 +2594,10 @@
   dependencies:
     styled-components "^5.3.0"
 
-"@osu-wams/utils@0.0.29":
-  version "0.0.29"
-  resolved "https://npm.pkg.github.com/download/@osu-wams/utils/0.0.29/cee56ee7076c3f3dafd2d04aca7b9c4520f6dea6#cee56ee7076c3f3dafd2d04aca7b9c4520f6dea6"
-  integrity sha512-VsKkw43HUFaLuZ83NCtfUckwZY1aOGy6ah5cmpd8GMPQ6u76vT8BT8T/rOCYyBDK87v+aFxvUZpYtkKNXkBIyA==
+"@osu-wams/utils@0.0.30":
+  version "0.0.30"
+  resolved "https://npm.pkg.github.com/download/@osu-wams/utils/0.0.30/8a1a2e569698864976f7036510e804ebeb0f2525#8a1a2e569698864976f7036510e804ebeb0f2525"
+  integrity sha512-dwEboQJzYDQaPVyTmFGXOEtDJVFUfhhtzLLjVdGoOE04eF/aX8zRtQt4kuRJ+4C0p2AqjSo1qxub8aZe8I37UQ==
   dependencies:
     "@osu-wams/lib" "^0.1.87"
     date-fns "^2.21.1"