From f1c9cd420b8384049f0fe0e554000e7b4e08a819 Mon Sep 17 00:00:00 2001 From: Sawjan Gurung Date: Tue, 6 Sep 2022 16:47:14 +0545 Subject: [PATCH] [gui-tests-only] Unskip vfs tests (#10073) * wait for files to sync and unskip vfs tests * remove unused step def --- test/gui/shared/steps/steps.py | 10 +++++----- test/gui/tst_vfs/test.feature | 4 +++- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/test/gui/shared/steps/steps.py b/test/gui/shared/steps/steps.py index 3bc6323bfb6..b65b8546313 100644 --- a/test/gui/shared/steps/steps.py +++ b/test/gui/shared/steps/steps.py @@ -423,11 +423,6 @@ def step(context, type, resource): waitForFileOrFolderToSync(context, resource, type) -@Given(r'user has waited for (file|folder) to be synced', regexp=True) -def step(context, type, resource): - waitForFileOrFolderToSync(context, resource, type) - - @When(r'the user waits for (file|folder) "([^"]*)" to have sync error', regexp=True) def step(context, type, resource): waitForFileOrFolderToHaveSyncError(context, resource, type) @@ -438,6 +433,11 @@ def step(context, type, resource): waitForFileOrFolderToBeSyncIgnored(context, resource, type) +@Given('user has waited for the files to be synced') +def step(context): + waitForRootFolderToSync(context) + + @Given(r'the user has waited for (file|folder) "([^"]*)" to be synced', regexp=True) def step(context, type, resource): waitForFileOrFolderToSync(context, resource, type) diff --git a/test/gui/tst_vfs/test.feature b/test/gui/tst_vfs/test.feature index 5bec8952224..c16f06112e1 100644 --- a/test/gui/tst_vfs/test.feature +++ b/test/gui/tst_vfs/test.feature @@ -1,4 +1,3 @@ -@skip Feature: Enable/disable virtual file support As a user @@ -9,6 +8,7 @@ Feature: Enable/disable virtual file support Scenario: Enable VFS Given user "Alice" has been created on the server with default attributes and without skeleton files And user "Alice" has set up a client with default settings + And user has waited for the files to be synced When the user enables virtual file support Then the "Disable virtual file support..." button should be available And VFS enabled baseline image should match the default screenshot @@ -17,12 +17,14 @@ Feature: Enable/disable virtual file support Scenario: VFS is disabled by default Given user "Alice" has been created on the server with default attributes and without skeleton files And user "Alice" has set up a client with default settings + And user has waited for the files to be synced Then VFS enabled baseline image should not match the default screenshot Scenario: Disable VFS Given user "Alice" has been created on the server with default attributes and without skeleton files And user "Alice" has set up a client with default settings + And user has waited for the files to be synced And the user has enabled virtual file support When the user disables virtual file support Then the "Enable virtual file support (experimental)..." button should be available \ No newline at end of file