Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] strict type and user literals for currency amounts #1587

Open
majestrate opened this issue Aug 11, 2022 · 0 comments
Open

[refactor] strict type and user literals for currency amounts #1587

majestrate opened this issue Aug 11, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@majestrate
Copy link

majestrate commented Aug 11, 2022 •
edited
Loading

internally, oxen currency amounts are atomic oxen as a uint64_t, which is not the same as an "oxen". this is an inherited artifact from upstream which has made multiple bugs happen.

we should use an explicitly constructable non ambiguous type for currency amounts with user literals for each denomination. ( 40_$OXEN 40_atomic_$OXEN etc or something )
@majestrate majestrate added the enhancement New feature or request label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@majestrate