"reward" vs "snode" payment types shouldn't be a distinction

[jagerman]

Wallet2 currently has this logic for coinbase txes:

      if (vout_index == 0) entry.type = wallet::pay_type::miner;
      else entry.type = wallet::pay_type::service_node;

so as a result, even before HF10, you'd sometimes see "miner" and sometimes "snode" depending on whether you were earning as the block producer or a later recipient. In HF10 we renamed "miner" to "reward" in the output, but that just means you now see "reward" or "snode" depending on whether you were the first wallet receiving a payment in a batch reward.

(This logic goes back to pre-snode days, when the first output was the miner wallet and later outputs were service node payments).

[mdPlusPlus]

This seems related to this issue: oxen-io/oxen-electron-gui-wallet#285