forked from monero-project/monero
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core_rpc_server_command_parser order #1606
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
RPC argument parsing (on dev) is currently doing things like this:
But this is broken because parsing has to happen in alphabetical order (because we support bt-encoded RPC, where we consume arguments, but arguments have to always be sorted).
Aside from the ordering,
get_values
is meant to take a list of all (or many) options at once, like this:aside from being slightly cleaner syntax, this will also catch (at runtime) the out-of-order keys and raise an exception.
The text was updated successfully, but these errors were encountered: