-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial feedback after migrating to csv2 #17
Comments
Also I have a row of data that completely breaksdown when it attempts to parse the position that contains a comma that needs to be skipped. I specified the quote character needs to be escaped.
|
Another issue has to do with std::min and std::max on windows. In my source cpp file that includes csv2.hpp needs to have a preprocessor define NOMINMAX in order to work around this as csv2 includes windows.h. See this for details. |
Prior to using csv2, I was using a different aria csv parser. That parser was simple but did not support a write API. After switching over, here are the problems I have encountered so far:
I am unable to access column values by index, so taking advantate of c++ structured bindings is not possible. The following structured binding trick was possible with the previous parser and unfortunately even using iterators this is not possible with csv2:
Upon further instead I have to do something along the following lines:
The row and cell iterators do not support operator+=(int) so unfortunately I cannot replace
with
Also there should be cbegin() and cend() const variants to each of the iterators. Visual studio returns squiggly performance warnings indicating that the modern for loop should allow the return value to bind to a const auto& row instead making a potentially large copy of the data which is returned from the csv2 API. i.e the following should be possible except the API returns a Row and not a const Row& - ditto for Column.
The text was updated successfully, but these errors were encountered: