-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty line ends on segfault #32
Comments
At the very least, the documentation should mention iterator-based loops and the fact that the first iterator should be tested for the end of row. In which case, adding an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the CSV file has an empty line, the parsing ends on a segfault.
At least the trailing newline should either be parsed out silently, or give raise to an explicit error rather than a segmentation fault.
Minimal example (can be copy/pasted into
test/main.cpp
):Note that the code above advertises a use-case that was not documented: parsing a table having row headers.
In that case, using iterator-based loops makes sense. But the
CellIterator
interface —while functional— lacks the expected interface:operator->
and a postfixoperator++
.The text was updated successfully, but these errors were encountered: