Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About model implementation differences #35

Open
sourcesur opened this issue Mar 1, 2024 · 3 comments
Open

About model implementation differences #35

sourcesur opened this issue Mar 1, 2024 · 3 comments

Comments

@sourcesur
Copy link

Hi, thanks for your effort and sharing the code!
The architecture blocks in the speech prompted text encoder and CFM decoder differ from the initial ones introduced in the paper. I would like to know what made you do the changes. Was the model not converging with official architecture?

@p0p4k
Copy link
Owner

p0p4k commented Mar 1, 2024

Just easier to implement and more modular. Keeping it open ended to make it more accessible to do experiments.

@sourcesur
Copy link
Author

I wanted to reproduce the results from the paper, so I used this repo (master branch) to train the model on LibriTTS. I trained it for 800k steps and longer but the overall generation quality is quite far from the official demo.
Have you tried reproducing the results?

@p0p4k
Copy link
Owner

p0p4k commented Mar 6, 2024

try to play around with the speech prompt encoder. I have not trained this model yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants