Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated with CryptoCompare API #4

Open
Tibo-lg opened this issue Apr 8, 2020 · 0 comments
Open

Integrated with CryptoCompare API #4

Tibo-lg opened this issue Apr 8, 2020 · 0 comments

Comments

@Tibo-lg
Copy link
Contributor

Tibo-lg commented Apr 8, 2020

For the first version we will get data from the cryptocompare API.

Objectives

  • Implement a client to the cryptocompare API.
  • Use the client to retrieve data and sign it when first requested.
  • Add unit and integration tests (might not be a good idea to use the actual cryptocompare api even for integration tests).

Technical considerations

  • It might be cleaner to put the API client in a separate repository for reusability/separation of concern.
  • The integration should be done through dependency injection so that it will be easy to integrate other data feeds in the future. This means defining a DataProvider interface and implementing it using the cryptocompare client. "Static dependency injection" (instantiated in the main) should be enough for now.
  • A private key will be required to produce signatures, this should be given to the application see this for some recommendation. As a first step putting it in a config file could be enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant