Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make text in the left-nav header more accessible #298

Closed
nikclayton opened this issue Dec 4, 2023 · 1 comment · Fixed by #773
Closed

Make text in the left-nav header more accessible #298

nikclayton opened this issue Dec 4, 2023 · 1 comment · Fixed by #773
Assignees
@nikclayton

Comments

@nikclayton
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The left-nav menu has text in the header showing the current account, and a disclosure triangle to switch accounts. These follow the normal text colours.

Behind this is the user's account header image.

This is a problem if the header image is dark (in light mode) or light (in dark mode) because the text and arrow may be difficult to see.

Describe the solution you'd like

The text colour should adapt to the colours of the account header image to ensure they are legible.
@nikclayton nikclayton self-assigned this Dec 4, 2023
@nikclayton
Copy link
Contributor Author

Note to self: more difficult than I'd like, see mikepenz/MaterialDrawer#2801

nikclayton added a commit that referenced this issue Jun 22, 2024
@nikclayton
fix: Ensure text in nav menu account header is legible
3fa499a 
The user might have set a profile header image that is close to the
colour of the text in the account header in the left navigation menu.
This can make the text difficult or impossible to see.

Work around this by drawing a partially transparent scrim behind the
text so it's always displayed over a background that makes the text
legible.

Fixes #298
@nikclayton nikclayton mentioned this issue Jun 22, 2024
Merged
nikclayton added a commit that referenced this issue Jun 22, 2024
@nikclayton
fix: Ensure text in nav menu account header is legible (#773)
1f2194c 
The user might have set a profile header image that is close to the
colour of the text in the account header in the left navigation menu.
This can make the text difficult or impossible to see.

Work around this by drawing a partially transparent scrim behind the
text so it's always displayed over a background that makes the text
legible.

Fixes #298
@github-project-automation github-project-automation bot moved this from Todo to Done in Pachli roadmap Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikclayton nikclayton

Labels
None yet
Projects
Pachli roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Ensure text in nav menu account header is legible pachli/pachli-android
1 participant
@nikclayton