Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples code contains provider verifications that does not publish results to broker #445

Closed
4 tasks done
neringaalt opened this issue Oct 28, 2023 · 2 comments · Fixed by #455
Closed
4 tasks done
Labels
area:examples Relating to the examples type:bug Something isn't working

Comments

@neringaalt
Copy link
Contributor

neringaalt commented Oct 28, 2023

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of pact-python.
  • I have read the console error message carefully (if applicable).

Description

It is a super easy to fix bug, but I was not able to open PR for this:
Examples code contains published_verification_results instead of publish_verification_results

Reproducible demo

No response

Steps to reproduce

I am running examples using poetry run pytest test_01_provider_fastapi.py -s

Expected behavior

Provider verification should be publish to the broker.

Actual behavior

Provider verification tests are passing, but results are not publish and have status pending.

Your environment

Poetry 1.6.1
Python 3.11
pact-python 2.0.1

Self-service

  • I'd be willing to fix this bug myself.
@JP-Ellis
Copy link
Contributor

Thanks for the bug report!

Is the bug just the typo? I'd be happy to help you make the PR, because you should be able to create one which requires creating a fork first. You then make the modifications in the fork and create the PR pulling changes from your fork into this repo.

Let me know how you go, and feel free to reach out if you have any other questions!

@JP-Ellis JP-Ellis added type:bug Something isn't working area:examples Relating to the examples labels Nov 1, 2023
@JP-Ellis JP-Ellis moved this to 📝 Backlog in Pact Python Nov 1, 2023
@neringaalt
Copy link
Contributor Author

PR for this #455

@github-project-automation github-project-automation bot moved this from 📝 Backlog to ✅ Completed in Pact Python Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:examples Relating to the examples type:bug Something isn't working
Projects
Status: ✅ Completed
Development

Successfully merging a pull request may close this issue.

2 participants