Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: v2.1.0 #394

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Release: v2.1.0 #394

merged 3 commits into from
Oct 3, 2023

Conversation

JP-Ellis
Copy link
Contributor

@JP-Ellis JP-Ellis commented Sep 25, 2023

Update pact standalone and bump version to get v2.1.0 out.

@YOU54F Not sure what your previous release process has been like :)

@JP-Ellis JP-Ellis self-assigned this Sep 25, 2023
@YOU54F
Copy link
Member

YOU54F commented Sep 25, 2023

i think someone is up with the changelog. we’ve got two files now?

it’s good to release small and release often, it’s all automated. the releasing document at the base of the repo should be up to date

once a release workflow is triggered, a maintainer will need to approve ( the user triggering the release can bypass that check with a note )

@JP-Ellis
Copy link
Contributor Author

Yeah, I was a little confused with the changelogs too. I noticed that commitizen is being used, but it produced a completely different changelog to the existing one. Also, the existing one appears to be a git log as opposed to an actual changelog (and end-users of Pact Python don't really need to know the chore commits in general, so the changelog need not include them).

@YOU54F
Copy link
Member

YOU54F commented Sep 26, 2023

Ahhh,

so the script/release_prep.sh is run for releases, which generates a changelog from the git log history, rather than with commitizen

https://github.com/pact-foundation/pact-python/blob/7c60dd5e0979907828b27ff7b9bb5069eec397c8/script/release_prep.sh#L21C3-L28C50

It would be good to update how you are generating the version number? and maybe update the release_prep.sh script.

PS, would you prefer releases to come via Pull reqs - currently they are triggered from HEAD

https://github.com/pact-foundation/pact-python/blob/master/RELEASING.md#preparing-the-release

which pushes back the updated changelog via the current process

Signed-off-by: JP-Ellis <josh@jpellis.me>
Fix a couple of minor issues with the publishing workflow:

- Only publish releases from tags starting with `v`
- Fix an incorrect name in the downloading of artifacts
- Fix snake_case to kebab-case in a publish parameter

Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis
Copy link
Contributor Author

JP-Ellis commented Oct 2, 2023

Fixed the doubling-up of changelogs, and created #400 to discuss updating the changelog format :) Let me know what you think. I'll push the v2.1.0 tag once this branch is merged.

@JP-Ellis JP-Ellis requested a review from YOU54F October 2, 2023 05:21
@JP-Ellis JP-Ellis merged commit 77124ee into master Oct 3, 2023
30 checks passed
@JP-Ellis JP-Ellis deleted the release/v2.1.0 branch October 3, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Completed
Development

Successfully merging this pull request may close these issues.

2 participants