-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: v2.1.0 #394
Release: v2.1.0 #394
Conversation
i think someone is up with the changelog. we’ve got two files now? it’s good to release small and release often, it’s all automated. the releasing document at the base of the repo should be up to date once a release workflow is triggered, a maintainer will need to approve ( the user triggering the release can bypass that check with a note ) |
Yeah, I was a little confused with the changelogs too. I noticed that commitizen is being used, but it produced a completely different changelog to the existing one. Also, the existing one appears to be a git log as opposed to an actual changelog (and end-users of Pact Python don't really need to know the chore commits in general, so the changelog need not include them). |
Ahhh, so the It would be good to update how you are generating the version number? and maybe update the release_prep.sh script. PS, would you prefer releases to come via Pull reqs - currently they are triggered from HEAD https://github.com/pact-foundation/pact-python/blob/master/RELEASING.md#preparing-the-release which pushes back the updated changelog via the current process |
Signed-off-by: JP-Ellis <josh@jpellis.me>
ed63559
to
86f45bd
Compare
Fix a couple of minor issues with the publishing workflow: - Only publish releases from tags starting with `v` - Fix an incorrect name in the downloading of artifacts - Fix snake_case to kebab-case in a publish parameter Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
86f45bd
to
b8bdc02
Compare
Fixed the doubling-up of changelogs, and created #400 to discuss updating the changelog format :) Let me know what you think. I'll push the |
Update pact standalone and bump version to get v2.1.0 out.
@YOU54F Not sure what your previous release process has been like :)