fix: handle nil response when determining webhook success status

pact-foundation · Feb 18, 2021 · 20ca9e6 · 20ca9e6
1 parent 601387b
commit 20ca9e6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/pact_broker/webhooks/webhook_execution_result.rb b/lib/pact_broker/webhooks/webhook_execution_result.rb
@@ -14,9 +14,11 @@ def initialize(request, response, logs, error = nil)
       end
 
       def success?
-        unless response.nil?
+        if response
           # Response HTTP Code must be in success list otherwise it is false
           PactBroker.configuration.webhook_http_code_success.include? response.code.to_i
+        else
+          false
         end
       end
     end

diff --git a/lib/pact_broker/webhooks/webhook_request_logger.rb b/lib/pact_broker/webhooks/webhook_request_logger.rb
@@ -117,9 +117,11 @@ def log_error uuid, e, base_url
       end
 
       def success?(response)
-        unless response.nil?
+        if response
           # Response HTTP Code must be in success list otherwise it is false
           PactBroker.configuration.webhook_http_code_success.include? response.code.to_i
+        else
+          false
         end
       end