fix: correct :false to false in verification decorator to correctly h…

…andle read only property providerName
pact-foundation · Aug 23, 2018 · 4af4ed1 · 4af4ed1
1 parent b0bb604
commit 4af4ed1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/pact_broker/api/decorators/verification_decorator.rb b/lib/pact_broker/api/decorators/verification_decorator.rb
@@ -5,7 +5,7 @@ module Api
     module Decorators
       class VerificationDecorator < BaseDecorator
 
-        property :provider_name, as: :providerName, writeable: :false
+        property :provider_name, as: :providerName, writeable: false
         property :provider_version_number, as: :providerApplicationVersion, writeable: false
         property :success
         property :execution_date, as: :verificationDate

diff --git a/spec/lib/pact_broker/api/decorators/verification_decorator_spec.rb b/spec/lib/pact_broker/api/decorators/verification_decorator_spec.rb
@@ -34,7 +34,9 @@ module Decorators
         let(:options) { { user_options: { base_url: 'http://example.org' } } }
 
 
-        subject { JSON.parse VerificationDecorator.new(verification).to_json(options), symbolize_names: true }
+        let(:json) { VerificationDecorator.new(verification).to_json(options) }
+
+        subject { JSON.parse json, symbolize_names: true }
 
         it "includes the success status" do
           expect(subject[:success]).to eq true