fix(matrix ui): fix home link

pact-foundation · Jun 1, 2020 · 67065b7 · 67065b7
1 parent c052bee
commit 67065b7
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 4 deletions.
diff --git a/lib/pact_broker/api/resources/base_resource.rb b/lib/pact_broker/api/resources/base_resource.rb
@@ -62,6 +62,11 @@ def base_url
           PactBroker.configuration.base_url || request.base_uri.to_s.chomp('/')
         end
 
+        # See comments for base_url in lib/pact_broker/doc/controllers/app.rb
+        def ui_base_url
+          PactBroker.configuration.base_url || ''
+        end
+
         def charsets_provided
           [['utf-8', :encode]]
         end

diff --git a/lib/pact_broker/api/resources/latest_pact.rb b/lib/pact_broker/api/resources/latest_pact.rb
@@ -36,7 +36,7 @@ def to_extended_json
         def to_html
           PactBroker.configuration.html_pact_renderer.call(
             pact, {
-              base_url: base_url,
+              base_url: ui_base_url,
               badge_url: "#{resource_url}/badge.svg"
           })
         end

diff --git a/lib/pact_broker/api/resources/pact.rb b/lib/pact_broker/api/resources/pact.rb
@@ -77,8 +77,8 @@ def to_extended_json
         def to_html
           PactBroker.configuration.html_pact_renderer.call(
             pact, {
-              base_url: base_url,
-              badge_url: badge_url_for_latest_pact(pact, base_url)
+              base_url: ui_base_url,
+              badge_url: badge_url_for_latest_pact(pact, ui_base_url)
           })
         end
 

diff --git a/lib/pact_broker/ui/views/matrix/show.haml b/lib/pact_broker/ui/views/matrix/show.haml
@@ -10,7 +10,7 @@
 
   .container
     .navbar-right
-      %a{href: base_url}
+      %a{href: "#{base_url}/"}
         Home
     %h1.page-header
       = title

diff --git a/spec/lib/pact_broker/api/resources/latest_pact_spec.rb b/spec/lib/pact_broker/api/resources/latest_pact_spec.rb
@@ -21,6 +21,7 @@ module Resources
           before do
             allow(PactBroker::Pacts::Service).to receive(:find_latest_pact).and_return(pact)
             allow(PactBroker.configuration.html_pact_renderer).to receive(:call).and_return(html)
+            allow_any_instance_of(LatestPact).to receive(:ui_base_url).and_return('http://example.org')
           end
 
           subject { get(path, nil, 'HTTP_ACCEPT' => accept) }

diff --git a/spec/lib/pact_broker/api/resources/pact_spec.rb b/spec/lib/pact_broker/api/resources/pact_spec.rb
@@ -24,6 +24,7 @@ module Resources
 
           before do
             allow_any_instance_of(Pact).to receive(:badge_url_for_latest_pact).and_return('http://badge')
+            allow_any_instance_of(Pact).to receive(:ui_base_url).and_return('http://example.org')
             allow(PactBroker::Pacts::Service).to receive(:find_pact).and_return(pact)
             allow(PactBroker.configuration.html_pact_renderer).to receive(:call).and_return(html)
           end