fix: gracefully handle contracts without interactions or messages in …

…deployment status warnings
pact-foundation · Aug 6, 2020 · 6c223e6 · 6c223e6
1 parent 4f18452
commit 6c223e6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/pact_broker/pacts/content.rb b/lib/pact_broker/pacts/content.rb
@@ -32,7 +32,8 @@ def sort
       end
 
       def interactions_missing_test_results
-        interactions.reject do | interaction |
+        return [] unless messages_or_interactions
+        messages_or_interactions.reject do | interaction |
           interaction['tests']&.any?
         end
       end

diff --git a/spec/lib/pact_broker/pacts/content_spec.rb b/spec/lib/pact_broker/pacts/content_spec.rb
@@ -308,6 +308,14 @@ module Pacts
           expect(subject.interactions_missing_test_results.count).to eq 1
         end
 
+        context "with no interactions" do
+          let(:pact_content) { {} }
+
+          it "does not blow up" do
+            expect(subject.interactions_missing_test_results.count).to eq 0
+          end
+        end
+
         context "with nil test results" do
           let(:test_results) { nil }