feat: don't double parse the incoming JSON body when checking if it i…

…s invalid. For @uglyog
pact-foundation · Feb 12, 2020 · bd74b82 · bd74b82
1 parent 73db9c2
commit bd74b82
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/pact_broker/api/resources/base_resource.rb b/lib/pact_broker/api/resources/base_resource.rb
@@ -84,7 +84,7 @@ def handle_exception e
         end
 
         def params
-          @params ||= JSON.parse(request.body.to_s, {symbolize_names: true}.merge(PACT_PARSING_OPTIONS))
+          @params ||= JSON.parse(request.body.to_s, { symbolize_names: true }.merge(PACT_PARSING_OPTIONS)) #Not load! Otherwise it will try to load Ruby classes.
         end
 
         def params_with_string_keys
@@ -123,7 +123,7 @@ def pacticipant_name
 
         def invalid_json?
           begin
-            JSON.parse(request_body, PACT_PARSING_OPTIONS) #Not load! Otherwise it will try to load Ruby classes.
+            params
             false
           rescue StandardError => e
             logger.info "Error parsing JSON #{e} - #{request_body}"