feat(webhooks): do not show backtrace in webhook test execution response

pact-foundation · May 24, 2019 · c8a8194 · c8a8194
1 parent d90c455
commit c8a8194
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/lib/pact_broker/api/decorators/webhook_execution_result_decorator.rb b/lib/pact_broker/api/decorators/webhook_execution_result_decorator.rb
@@ -8,7 +8,6 @@ module Decorators
       class WebhookExecutionResultDecorator < BaseDecorator
         class ErrorDecorator < BaseDecorator
           property :message
-          property :backtrace
         end
 
         class HTTPRequestDecorator < BaseDecorator

diff --git a/spec/features/execute_webhook_spec.rb b/spec/features/execute_webhook_spec.rb
@@ -82,8 +82,8 @@
 
     subject { post path; last_response }
 
-    it "returns a 500 response" do
-      expect(subject.status).to be 500
+    it "returns a 200 response" do
+      expect(subject.status).to be 200
     end
 
     it "does not save a TriggeredWebhook" do

diff --git a/spec/lib/pact_broker/api/decorators/webhook_execution_result_decorator_spec.rb b/spec/lib/pact_broker/api/decorators/webhook_execution_result_decorator_spec.rb
@@ -43,10 +43,6 @@ module Decorators
             it "includes the message" do
               expect(subject[:error][:message]).to eq 'message'
             end
-
-            it "includes the backtrace" do
-              expect(subject[:error][:backtrace]).to eq ['blah','blah']
-            end
           end
 
           context "when there is a request" do