fix: do not error when no environment is found by name

PACT-1402

lib/pact_broker/api/resources/environments.rb

@@ -60,7 +60,7 @@ def uuid
 
         def environments
           @environments ||= if request.query["name"]
-                              [environment_service.find_by_name(request.query["name"])]
+                              [environment_service.find_by_name(request.query["name"])].compact
                             else
                               environment_service.find_all
                             end

spec/features/get_environments_spec.rb

@@ -7,24 +7,30 @@
   end
   let(:path) { PactBroker::Api::PactBrokerUrls.environments_url }
   let(:headers) { {"HTTP_ACCEPT" => "application/hal+json"} }
-  let(:response_body) { JSON.parse(last_response.body, symbolize_names: true)}
+  let(:response_body) { JSON.parse(subject.body, symbolize_names: true)}
 
   subject { get(path, nil, headers) }
 
   it { is_expected.to be_a_hal_json_success_response }
 
   it "returns the environments" do
-    subject
     expect(response_body[:_embedded][:environments].size).to be 2
   end
 
   context "by name" do
     let(:path) { PactBroker::Api::PactBrokerUrls.environments_url + "?name=test" }
 
     it "returns the environment with the matching name" do
-      subject
       expect(response_body[:_embedded][:environments].size).to be 1
       expect(response_body[:_embedded][:environments].first[:name]).to eq "test"
     end
+
+    context "when no environment exists" do
+      let(:path) { PactBroker::Api::PactBrokerUrls.environments_url + "?name=foo" }
+
+      it "returns an empty list" do
+        expect(response_body[:_embedded][:environments].size).to be 0
+      end
+    end
   end
 end