fix(can-i-deploy): allow new provider to be introduced to existing co…

…nsumer without can-i-deploy having circular dependency issues
pact-foundation · Mar 18, 2022 · e43974c · e43974c
1 parent 145dea9
commit e43974c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/lib/pact_broker/matrix/repository.rb b/lib/pact_broker/matrix/repository.rb
@@ -118,7 +118,7 @@ def integrations_where_specified_selector_is_consumer(resolved_specified_selecto
                 consumer_name: integration[:consumer_name],
                 provider_id: integration[:provider_id],
                 provider_name: integration[:provider_name],
-                required: true
+                required: true # synchronous consumer requires the provider to be present
               )
             end
         end
@@ -130,16 +130,13 @@ def integrations_where_specified_selector_is_provider(resolved_specified_selecto
                                                       .eager(:consumer, :provider)
                                                       .all
 
-        destination_selector = PactBroker::Matrix::UnresolvedSelector.new(options.slice(:latest, :tag, :branch, :environment_name).compact)
-        required = PactBroker::Domain::Version.for_selector(destination_selector).pacticipants_set
-
         integrations_involving_specified_providers.collect do | integration |
           Integration.from_hash(
             consumer_id: integration.consumer.id,
             consumer_name: integration.consumer.name,
             provider_id: integration.provider.id,
             provider_name: integration.provider.name,
-            required: required.member?(integration.consumer.id)
+            required: false # synchronous provider does not require the consumer to be present
           )
         end
       end

diff --git a/spec/fixtures/approvals/matrix_integration_spec.approved.json b/spec/fixtures/approvals/matrix_integration_spec.approved.json
@@ -177,9 +177,9 @@
     ]
   },
   "PactBroker::Matrix::Service find when adding a new provider p2 v1 is allowed to be deployed because the version of c1 that is in test does not care about p2": {
-    "deployable": null,
+    "deployable": true,
     "reasons": [
-      "PactBroker::Matrix::PactNotVerifiedByRequiredProviderVersion"
+      "PactBroker::Matrix::NoDependenciesMissing"
     ]
   }
 }
diff --git a/spec/lib/pact_broker/matrix/integration_spec.rb b/spec/lib/pact_broker/matrix/integration_spec.rb
@@ -536,7 +536,7 @@ module Matrix
               ]
             end
 
-            it "is allowed to be deployed because the version of c1 that is in test does not care about p2", pending: true do
+            it "is allowed to be deployed because the version of c1 that is in test does not care about p2" do
               expect(subject.deployment_status_summary).to be_deployable
             end
           end