Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(webhooks): use path to initialise http request, rather than full URL
This is required to make the request work for the slack notifications API, which returns a 302 if the full URL is used. ¯\_(ツ)_/¯ eg. SSL established <- "POST https://hooks.slack.com/services/TOKEN vs SSL established <- "POST /services/TOKEN
- Loading branch information
ecbac9a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out this is an issue in other scenarios also, so good to have fixed it!
ecbac9a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So strange that this code hasn't changed for years, and all of a sudden there is an issue noticed twice in two days. I wonder if a new version of some widely used server software has come out recently.