Skip to content
This repository has been archived by the owner on Apr 22, 2019. It is now read-only.

Propogate energy values across all items in an ore dictionary reference #1056

Open
jediminer543 opened this issue May 24, 2016 · 2 comments
Open
Labels

Comments

@jediminer543
Copy link

jediminer543 commented May 24, 2016

Hello

Could you add the ability for the energy value calculations to propogate any changes accros all oredictionary references that don't have a defined value (or have some illogical one). This causes problems with furnaces outputting an ingot that has no EMC value. For example, in my set up currently:

Mod EMC
Forestry No EMC
Galacticraft No EMC
Industrial Craft 0.009
Project Red No EMC
Railcraft No EMC
Tinkers Construct No EMC
Thermal Foundation 192

As most ingots lack an EMC value, this then means upstream recipes will sometimes lose their EMC values.

On: 0.3.0.521

@pahimar
Copy link
Owner

pahimar commented May 28, 2016

I'm not clear what you are experiencing here. The algorithm works like this

https://github.com/pahimar/Equivalent-Exchange-3/blob/master/src/main/java/com/pahimar/ee3/exchange/EnergyValueRegistry.java#L61-L98

@pterolatypus
Copy link

pterolatypus commented Jun 29, 2016

If I've understood correctly, what OP wants is for direct mappings of OreDictionary registered items to be automatically promoted to OD mappings under certain circumstances. My suggestion would be to do a pass over the pre-calc map before you begin calculating new values and promote anything which has exactly one OD entry, unless a cheaper one is already registered.

Edit: Opened a pull request for your consideration. #1089

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants