Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normals appear to be incorrect #3

Open
carstenschwede opened this issue May 15, 2021 · 2 comments
Open

Normals appear to be incorrect #3

carstenschwede opened this issue May 15, 2021 · 2 comments

Comments

@carstenschwede
Copy link

carstenschwede commented May 15, 2021 •
edited
Loading

It looks like the normals appear to be calculated incorrectly.
When used in combination with an environment map and a reflective material it becomes apparent:

Screenshot 2021-05-15 at 14 26 19
Screenshot 2021-05-15 at 14 26 09
@carstenschwede
Copy link
Author

carstenschwede commented May 15, 2021 •
edited
Loading

Vertex normals are fine. Seems to be an issue with the envMap shading.

Screenshot 2021-05-15 at 14 58 27

@pailhead
Copy link
Owner

pailhead commented Jan 9, 2024

Ouch, i totally neglected this repo. Curious issue, since the normals seem to be correct. There have been many differet (better) implementations of this, so it might be worth revisiting this whole approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carstenschwede @pailhead