Conditionally packaging a buildpack or an extension #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdimsdale
previously approved these changes
Jun 6, 2024
implementation/scripts/package.sh
Outdated
| buildpack package "${output}" \ | ||
| --path "${BUILD_DIR}/buildpack.tgz" \ | ||
| --format file | ||
| pushd "${BUILD_DIR}/cnbdir" > /dev/null |
There was a problem hiding this comment.
Initially i was confused why we were not doing something similar to the pack buildpack package --path <path> below, then I realized that pack extension package doesn't have that feature.
I opened this feature request on pack -if/when that lands we can clean this up.
|
@ForestEckhardt wondering if you might have time to help review/land? |
implementation/scripts/package.sh
Outdated
| buildpack::archive "${version}" | ||
| buildpackage::create "${output}" | ||
| buildpack_type=buildpack | ||
| if [ -f "extension.toml" ]; then |
There was a problem hiding this comment.
Does this need to be an absolute path as well to solve the same problem as seen in #947?
There was a problem hiding this comment.
@ForestEckhardt There was no error on that one, but I changed it anyway to point to an absolute path. I also rebased the branch.
pacostas
force-pushed
the
package-script-common
branch
from
5141169 to
073f2a3
Compare
pacostas
force-pushed
the
package-script-common
branch
from
073f2a3 to
8319f9b
Compare
pacostas
force-pushed
the
package-script-common
branch
from
8319f9b to
c418eb5
Compare
ForestEckhardt
approved these changes
Jun 17, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the package.sh script to conditionally package a buildpack or an extension according to whether is an extension or a buildpack.
The way this is implemented is to check whether the extension file exists on the directory, otherwise, it fallbacks to the default behavior of packaging a buildpack.
Test results:
Use Cases
Checklist