-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated data are not Error checked #6
Comments
The reason for NaN should have either been a parse error with getting the field, in which case the CollectedData should have been false, or if the WAS or Shares is 0. Which again would have been a parsing error. What is the scenario in which you run into this case and need this check. The check in itself is harmless, but I am trying to understand why to get there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dps specifically needs to be checked otherwise *math.Inf or *math.NaN values can mess with the json encoding resulting in a fatal crash as the encoding library does not handle these values for you.
data_def.go changes:
The text was updated successfully, but these errors were encountered: