Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing a streaming response body hangs if the server doesn't write #1814

Open
sfackler opened this issue Nov 7, 2022 · 0 comments
Open

Comments

@sfackler
Copy link
Member

sfackler commented Nov 7, 2022

What happened?

When closing the response body for a request to an endpoint that the server never finishes writing to, the close call hangs until the socket-level read timeout is reached inside of hasSubstantialRemainingData. Currently the only way to avoid the hang is to intentionally not close the response body, which can then trigger the leak detection warnings in Dialogue.

What did you want to happen?

Dialogue should be able to handle hung responses. Either the hasSubstantialRemainingData call should happen under a fairly aggressive timeout, or there should be some way to close the response without trying to consume any more of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant