setting SERVER_NAME
does not restrict routing for both subdomain_matching
and host_matching
#5634
+98
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a bunch in #5553 about investigating this. Essentially, we need to pass
""
to disable subdomain matching, notNone
. The two tests that had to change were accidentally working because settingSERVER_NAME
was bypassingsubdomain_matching = False
, and the tests should have been setting it toTrue
since they were working with subdomains.Now
SERVER_NAME
only affects routing ifsubdomain_matching=True
, in which case it correctly limits routing to subdomains under that name.fixes #5553