Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement packet versioning scheme. #30

Open
jchv opened this issue Jul 15, 2021 · 1 comment
Open

Implement packet versioning scheme. #30

jchv opened this issue Jul 15, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jchv
Copy link
Collaborator

jchv commented Jul 15, 2021

Right now, there are 2 properties that select how the packet parser works:

  • Whether or not the packet is a server packet or a client packet.
  • Which service the packet is (login, game, message)

In addition to this, we need some way to select a version. Because we do not know anything about PangYa's server infrastructure, we should rely on client versions as the basis for protocol versioning.

@jchv jchv added the enhancement New feature or request label Jul 15, 2021
@jchv
Copy link
Collaborator Author

jchv commented Jul 15, 2021

Some preliminary work was done in #32, but we still need:

  • Actual packets with versioning
  • Good UI support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant