Lobby updates do not work as expected

[jchv]

When users leave and join rooms and exit and enter the lobby, the user list is very prone to falling out of sync. Pangbox likely handles the lobby incorrectly.

The lobby sync we do after you exit a game does not seem to work. I suspect that the lobby updates are supposed to continue even when you are in a game, which is annoying. We could potentially just make a diff of the state from before and do a minimal update when a game ends, but it'd be better to just follow what the game does, even if it seems unnecessary. Probably need to check pantrant.

[hex-agon]

Just chiming in that it is indeed the case, here's a pcap from pangya th:

As highlighted in blue, those are the packets sent when starting a game and while i'm still in the game i am receiving user & room census packets (highlighted in orange)

[jchv]

Thanks! I'll just fix the lobby behavior at some point...