Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Attach Modal Dialogs Gnome setting #904

Open
jtaala opened this issue Jul 21, 2024 · 3 comments
Open

Support Attach Modal Dialogs Gnome setting #904

jtaala opened this issue Jul 21, 2024 · 3 comments
Labels
enhancement Adds a new feature or extends scope help wanted Don't hesitate to participate!

Comments

@jtaala
Copy link
Collaborator

jtaala commented Jul 21, 2024

Related to #902.

Due to some (previously observed) complexities with PaperWM's tiling/window-manage model, Gnome's "Attach Modal Dialogs" mode for windows is not currently compatible with PaperWM.

As such, this Gnome setting is a managed setting in PaperWM: https://github.com/paperwm/PaperWM?tab=readme-ov-file#recommended-gnome-shell-settings

This request is to add specific support for this Gnome windowing option.

@jtaala jtaala added enhancement Adds a new feature or extends scope help wanted Don't hesitate to participate! labels Jul 21, 2024
@jtaala
Copy link
Collaborator Author

jtaala commented Jul 21, 2024

Some notes from previously observed behaviour with "Attach Modal Dialogs":

  • comment out this line to stop PaperWM managing (and disabling) this Gnome setting:
    saveRuntimeDisable(mutterSettings, 'attach-modal-dialogs', false);
  • we should be able to identify a modal dialog (metaWindow) with something like
metaWindow.get_window_type() === Meta.WindowType.MODAL_DIALOG
  • I think we'd need specific logic to manage the placement (and moving with parent) within our tiling model.

@jtaala jtaala changed the title Support Attach Modal Dialogs for windows Support Attach Modal Dialogs Gnome setting Jul 21, 2024
@Lythenas
Copy link
Collaborator

I briefly tried out the Attach Modal Dialogs setting and the main issue I encountered is that when a window moves out of the screen the dialog will move to the next monitor. I don't know if there are other issues, but that might be manageable by paperwm (e.g. hide or clip the dialog if the parent is outside of the monitor).

@jtaala
Copy link
Collaborator Author

jtaala commented Jul 22, 2024

Thanks @Lythenas. I also noticed that notice a model "dialog" moves the parent window instead, with the modal dialog staying in it's original position, until I release a button (then it snaps to the parent window) - which looks very strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds a new feature or extends scope help wanted Don't hesitate to participate!
Projects
None yet
Development

No branches or pull requests

2 participants