Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line drawing is "bad" when "height" < "width" #14

Open
udoschneider opened this issue Jun 16, 2022 · 0 comments
Open

Line drawing is "bad" when "height" < "width" #14

udoschneider opened this issue Jun 16, 2022 · 0 comments

Comments

@udoschneider
Copy link

The current line drawing implementation uses a simple step-x based approach. This leads to bad results for very steep (e.g. nearly vertical) lines.
udoschneider added a commit to udoschneider/oled that referenced this issue Jun 16, 2022
@udoschneider
Fix & improve line drawing code
8d42c74 
Fixes pappersverk#13, pappersverk#14

Replace general coordinate sorting with specific sorting for line_h/line_v.

Replace generic x-based line drawing with standard Bresenham drawing
which provides better results in all octants.
@udoschneider udoschneider mentioned this issue Jun 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@udoschneider