Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node.serviceAccountName property and fully replace with serviceAccount.name #215

Open
PierreBesson opened this issue Feb 8, 2023 · 0 comments
Labels

Comments

@PierreBesson
Copy link
Contributor

PierreBesson commented Feb 8, 2023

The service account name is already defined in serviceAccount.name, so it's strange that it's possible to redefine it in node.serviceAccountName and unclear what purpose it has.

Note apparently this is mandatory to set it to the right value for Vault auth to work:

        vault.hashicorp.com/role: {{ .Values.node.vault.authRole | default (include "node.serviceAccountName" .) | squote }}
@PierreBesson PierreBesson added the P2 label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant