Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display the git revision version information #105

Merged
merged 2 commits into from
Oct 30, 2024
Merged

display the git revision version information #105

merged 2 commits into from
Oct 30, 2024

Conversation

xermicus
Copy link
Member

Looks like this:

❯ resolc --version
Solidity frontend for the revive compiler v0.1.0 rev-36d9317 (LLVM build (18, 1, 8))

Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
@smiasojed
Copy link
Collaborator

smiasojed commented Oct 30, 2024

could we align it to the solc version format?
0.1.0-dev+commit.36d9317

Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
@xermicus
Copy link
Member Author

Why? This isn't supposed to be machine readable and we also want to display the LLVM build used.

Changed it to append +commit.rev as you suggested.

@smiasojed
Copy link
Collaborator

OK, It is fine to have llvm version there.
Please consider updating contract metadata with correct compiler version

@xermicus
Copy link
Member Author

Please consider updating contract metadata with correct compiler version

Yep, will do that too, thanks

@xermicus xermicus merged commit 68564f9 into main Oct 30, 2024
2 checks passed
@xermicus xermicus deleted the cl/rev-parse branch October 30, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants