Implement delegate_call #80
Open
+547
−372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xermicus
reviewed
Oct 14, 2024
| address public sender; | ||
| uint256 public value; | ||
|
|
||
| event DidSetVars(); |
There was a problem hiding this comment.
Testing this is irrelevant here? Keeping the fixtures as concise as possible eases debugging them :)
There was a problem hiding this comment.
just making sure emitted event belongs to caller and not callee
| @@ -43,6 +43,7 @@ test_spec!(call, "Caller", "Call.sol"); | |||
| test_spec!(transfer, "Transfer", "Transfer.sol"); | |||
| test_spec!(return_data_oob, "ReturnDataOob", "ReturnDataOob.sol"); | |||
| test_spec!(immutables, "Immutables", "Immutables.sol"); | |||
| test_spec!(delegate, "Delegate", "Delegate.sol"); | |||
There was a problem hiding this comment.
This could use some better test coverage, i.e. calling into non-existent accounts, plain accounts, recursively into self (from runtime code and the constructor).
There was a problem hiding this comment.
will add more cases
|
@ermalkaleci we will fix the CI first |
|
@ermalkaleci merging main will fix the CI issue |
xermicus
reviewed
Nov 21, 2024
|
@xermicus merge conflicts resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
TODO: