Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release CI #97

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Release CI #97

wants to merge 8 commits into from

Conversation

AndWeHaveAPlan
Copy link

@AndWeHaveAPlan AndWeHaveAPlan commented Oct 25, 2024

.github/Dockerfile-llvm Outdated Show resolved Hide resolved

COPY build-llvm.sh .

RUN bash -c ./build-llvm.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN bash -c ./build-llvm.sh
RUN bash -c ./build-llvm.sh

We probably need to modify the build-llvm.sh file to use other flags. AFAIK @xermicus discovered that some other flags are needed to it statically links against LLVMs libc++ instead of gccs libstdc++.

Copy link
Member

@xermicus xermicus Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when I tried cross compiling to musl using the current build script, resolc was still dyn linked against libstdc++ (and segfaulted with an LLVM panic message). See also this comment in the related issue.

@wpt967 mentioned he was looking into it, what is the status?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I told @wpt967 to de-pritotize this one since we are only supporting compilation REMIX for now. Until we have proper releases.

alvicsam and others added 2 commits October 25, 2024 09:49
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
@xermicus
Copy link
Member

We also want to test it by running cargo test --workspace after installing the static resolc binary to ensure it works.

Copy link
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to change the inkwell dependency to use my branch here (why is explained in the related issue).

@xermicus
Copy link
Member

xermicus commented Oct 29, 2024

You will also need to change the inkwell dependency to use my branch here (why is explained in the related issue).

This is now no longer needed. The main branch should cross compile fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants