-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release CI #97
base: main
Are you sure you want to change the base?
Release CI #97
Conversation
|
||
COPY build-llvm.sh . | ||
|
||
RUN bash -c ./build-llvm.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN bash -c ./build-llvm.sh | |
RUN bash -c ./build-llvm.sh |
We probably need to modify the build-llvm.sh
file to use other flags. AFAIK @xermicus discovered that some other flags are needed to it statically links against LLVMs libc++
instead of gccs libstdc++
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, when I tried cross compiling to musl using the current build script, resolc was still dyn linked against libstdc++
(and segfaulted with an LLVM panic message). See also this comment in the related issue.
@wpt967 mentioned he was looking into it, what is the status?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I told @wpt967 to de-pritotize this one since we are only supporting compilation REMIX for now. Until we have proper releases.
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
We also want to test it by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will also need to change the inkwell
dependency to use my branch here (why is explained in the related issue).
This is now no longer needed. The |
cc https://github.com/paritytech/ci_cd/issues/1068