From 5e26dd9cc3e999140a741779b82cce99d9582c17 Mon Sep 17 00:00:00 2001
From: jdolence <jcdolence@gmail.com>
Date: Thu, 17 Aug 2023 12:58:19 -0600
Subject: [PATCH] fix typo, fix bug in FlagCollection, and silence a compiler
 warning

---
 src/interface/metadata.hpp         | 4 +++-
 src/interface/sparse_pack_base.hpp | 2 ++
 src/mesh/mesh.hpp                  | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/interface/metadata.hpp b/src/interface/metadata.hpp
index 6d6f47aa1ace..f3f7fb102429 100644
--- a/src/interface/metadata.hpp
+++ b/src/interface/metadata.hpp
@@ -230,7 +230,9 @@ class Metadata {
     FlagCollection(MetadataFlag first, Args... args)
         : FlagCollection({first, std::forward<Args>(args)...}, false) {}
     // Check if set empty
-    bool Empty() const { return (unions_.empty() && intersections_.empty()); }
+    bool Empty() const {
+      return (unions_.empty() && intersections_.empty() && exclusions_.empty());
+    }
     // Union
     template <template <class...> class Container_t, class... extra>
     void TakeUnion(const Container_t<MetadataFlag, extra...> &flags) {
diff --git a/src/interface/sparse_pack_base.hpp b/src/interface/sparse_pack_base.hpp
index 97c95995c8ac..6fe3e3045488 100644
--- a/src/interface/sparse_pack_base.hpp
+++ b/src/interface/sparse_pack_base.hpp
@@ -193,6 +193,8 @@ struct PackDescriptor {
         var_group_names.push_back(std::to_string(vg));
       return var_group_names;
     }
+    // silence compiler warnings about no return statement
+    return std::vector<std::string>();
   }
 };
 } // namespace impl
diff --git a/src/mesh/mesh.hpp b/src/mesh/mesh.hpp
index d32b389b93ed..0fe70fca445b 100644
--- a/src/mesh/mesh.hpp
+++ b/src/mesh/mesh.hpp
@@ -211,7 +211,7 @@ class Mesh {
 
   // expose a mesh-level call to get lists of variables from resolved_packages
   template <typename... Args>
-  std::vector<std::string> GetVariablesNames(Args &&...args) {
+  std::vector<std::string> GetVariableNames(Args &&...args) {
     return resolved_packages->GetVariableNames(std::forward<Args>(args)...);
   }