Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a global variable for whether simulation is a restart #1179

Merged
merged 11 commits into from
Sep 25, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Sep 21, 2024

PR Summary

It would be convenient downstream to be able to access is_restart as a global variable (when determining whether input parameters are set or not set appropriately only during initialization) -- right now whether we're restarted is hard to access outside driver classes or ParthenonManager. This PR adds Globals::is_restart set at the same time as Globals::my_rank.

Along the way I also added a soft_equiv function to utils/robust.hpp which would also be useful downstream.

I also renamed tst/unit/kokkos_abstraction.cpp -> tst/unit/test_kokkos_abstraction.cpp for consistency. Stop me if there's a reason to not do that.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

src/globals.cpp Show resolved Hide resolved
src/utils/robust.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/utils/robust.hpp Outdated Show resolved Hide resolved
brryan and others added 2 commits September 24, 2024 09:55
Co-authored-by: Jonah Miller <jonah.maxwell.miller@gmail.com>
@brryan brryan enabled auto-merge (squash) September 24, 2024 15:58
@brryan brryan disabled auto-merge September 25, 2024 21:44
@brryan brryan enabled auto-merge (squash) September 25, 2024 21:44
@brryan brryan merged commit 3de592d into develop Sep 25, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants