-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a global variable for whether simulation is a restart #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdempsey90
approved these changes
Sep 22, 2024
Yurlungur
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Jonah Miller <jonah.maxwell.miller@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
It would be convenient downstream to be able to access
is_restart
as a global variable (when determining whether input parameters are set or not set appropriately only during initialization) -- right now whether we're restarted is hard to access outside driver classes orParthenonManager
. This PR addsGlobals::is_restart
set at the same time asGlobals::my_rank
.Along the way I also added a
soft_equiv
function toutils/robust.hpp
which would also be useful downstream.I also renamed
tst/unit/kokkos_abstraction.cpp
->tst/unit/test_kokkos_abstraction.cpp
for consistency. Stop me if there's a reason to not do that.PR Checklist