Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project layout violates Vaadin rules #87

Open
envas opened this issue Jul 20, 2017 · 0 comments
Open

Project layout violates Vaadin rules #87

envas opened this issue Jul 20, 2017 · 0 comments

Comments

@envas
Copy link

envas commented Jul 20, 2017

Looking at the project layout I see a Vaadin design rules violations.

The code from client package is referenced by the non-client code. For example fi.jasoft.dragdroplayouts.client.ui.Constants are referenced from server side code. It means, the client binary must be deployed as part of the jar file on the server, although it should be only deployed as the javascript compiled by GWT.

Clean designed AddOn should the source code split between the client, shared, and the server side parts. Have a look at the Vaadin sources. Proper design is important for deployments on the servers with limited resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant